A channel's message slots are named from the client, on every backend
The IR called them react-message and django-message, so a FastAPI channel had to declare a DjangoMessage. They are client-message and server-message now, and the direction words hold wherever a channel is declared: Params / ClientMessage / ServerMessage, with mizan-core deriving <Pascal>Params and friends so no backend names a type itself. Django's ReactChannel and FastAPI's ReactChannel are both Channel. mizan-fastapi never registered a channels extension, so build_ir() emitted no channel at all and every payload type was invisible to codegen. It registers one now. RegistryExtension is an ABC requiring all(), which is what the IR reads — an extension that cannot enumerate its registrations no longer exists. The gate that should have caught the rename could not: tests/afi registered no channel because mizan-rust had no channel registry to register one in, so a five-package rename of the wire contract passed byte-parity without a channel byte crossing it. mizan-rust grows ChannelSlotKind, a CHANNELS slice, a #[mizan::channel] macro, and KDL emission whose wire_to_pascal matches Python's split; the AFI fixture now carries a channel with every slot and one with a single slot, so all three backends prove the contract byte for byte. MizanChannel held three Option<String> beside three has_*() predicates and unwrapped them with defaults; it holds an ordered slot vector, so an absent slot is absent rather than defaulted. The channels target emitted a React hooks file that a stage1-only consumer could not compile — react emits that now. The codegen's parity tests byte-compared emitted source against baselines without ever compiling it: they compile the generated crate and run its tests, import the generated Python package and call every method, and typecheck each TypeScript target against a consumer. Also fixed at source: app_visitor printed its import diagnostic to stdout, the stream export_mizan_ir writes KDL to, so a failed import silently corrupted the IR; the apps root was hardcoded to "apps"; _default_literal crashed build_ir on any non-JSON-serializable field default; Django and mizan-core derived Pascal names two different ways, disagreeing on every dotted channel name. ir.py builds a document and renders templates/ir/document.kdl.j2 rather than appending KDL strings with hand-tracked indentation, and named types resolve to a fixed point — a model reachable only through a union branch was referenced by a ref that no type block ever defined. The rest is the write-gate's own classifiers run over the standing tree: relative imports, silent swallows, Protocol contracts that should be ABCs, emitters hand-rendering target source, catch-all arms over closed enums, and comments narrating the project rather than the code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -1,143 +1,90 @@
|
||||
"""
|
||||
REAL integration tests for notes CRUD over HTTP.
|
||||
|
||||
Every test makes actual HTTP requests to a live Django server.
|
||||
"""
|
||||
|
||||
import json
|
||||
"""Notes CRUD driven over HTTP against a live Django server."""
|
||||
|
||||
from django.test import LiveServerTestCase
|
||||
from urllib.request import urlopen, Request
|
||||
|
||||
from tests.live_http import LiveRPCMixin
|
||||
|
||||
|
||||
class RealHTTPMixin:
|
||||
def _session_init(self):
|
||||
url = f"{self.live_server_url}/api/mizan/session/"
|
||||
resp = urlopen(Request(url))
|
||||
cookies = resp.headers.get_all("Set-Cookie") or []
|
||||
for cookie in cookies:
|
||||
if "csrftoken=" in cookie:
|
||||
self._csrf_token = cookie.split("csrftoken=")[1].split(";")[0]
|
||||
self._cookies = f"csrftoken={self._csrf_token}"
|
||||
return
|
||||
self._csrf_token = None
|
||||
self._cookies = ""
|
||||
|
||||
def _call(self, fn: str, args: dict | None = None):
|
||||
url = f"{self.live_server_url}/api/mizan/call/"
|
||||
body = json.dumps({"fn": fn, "args": args or {}}).encode()
|
||||
req = Request(url, data=body, method="POST")
|
||||
req.add_header("Content-Type", "application/json")
|
||||
if self._csrf_token:
|
||||
req.add_header("X-CSRFToken", self._csrf_token)
|
||||
if self._cookies:
|
||||
req.add_header("Cookie", self._cookies)
|
||||
resp = urlopen(req)
|
||||
return json.loads(resp.read())
|
||||
|
||||
|
||||
class NotesCRUDTests(RealHTTPMixin, LiveServerTestCase):
|
||||
"""Full CRUD lifecycle over real HTTP."""
|
||||
|
||||
class NotesCRUDTests(LiveRPCMixin, LiveServerTestCase):
|
||||
def setUp(self):
|
||||
self._session_init()
|
||||
self.session_init()
|
||||
|
||||
def test_list_notes_empty(self):
|
||||
data = self._call("list_notes")
|
||||
result = self.result("list_notes")
|
||||
|
||||
self.assertFalse(data["error"])
|
||||
self.assertEqual(data["data"]["notes"], [])
|
||||
self.assertEqual(data["data"]["count"], 0)
|
||||
self.assertEqual(result["notes"], [])
|
||||
self.assertEqual(result["count"], 0)
|
||||
|
||||
def test_create_note(self):
|
||||
data = self._call("create_note", {"title": "First Note", "content": "Hello!"})
|
||||
result = self.result("create_note", {"title": "First Note", "content": "Hello!"})
|
||||
|
||||
self.assertFalse(data["error"])
|
||||
self.assertEqual(data["data"]["title"], "First Note")
|
||||
self.assertEqual(data["data"]["content"], "Hello!")
|
||||
self.assertFalse(data["data"]["pinned"])
|
||||
self.assertIn("id", data["data"])
|
||||
self.assertIn("created_at", data["data"])
|
||||
self.assertEqual(result["title"], "First Note")
|
||||
self.assertEqual(result["content"], "Hello!")
|
||||
self.assertFalse(result["pinned"])
|
||||
self.assertIn("id", result)
|
||||
self.assertIn("created_at", result)
|
||||
|
||||
def test_create_and_list(self):
|
||||
self._call("create_note", {"title": "Note A"})
|
||||
self._call("create_note", {"title": "Note B"})
|
||||
self.result("create_note", {"title": "Note A"})
|
||||
self.result("create_note", {"title": "Note B"})
|
||||
|
||||
data = self._call("list_notes")
|
||||
self.assertFalse(data["error"])
|
||||
self.assertEqual(data["data"]["count"], 2)
|
||||
titles = [n["title"] for n in data["data"]["notes"]]
|
||||
result = self.result("list_notes")
|
||||
self.assertEqual(result["count"], 2)
|
||||
titles = [n["title"] for n in result["notes"]]
|
||||
self.assertIn("Note A", titles)
|
||||
self.assertIn("Note B", titles)
|
||||
|
||||
def test_get_note_by_id(self):
|
||||
create = self._call("create_note", {"title": "Get Me", "content": "Specific"})
|
||||
note_id = create["data"]["id"]
|
||||
note_id = self.result("create_note", {"title": "Get Me", "content": "Specific"})["id"]
|
||||
|
||||
data = self._call("get_note", {"id": note_id})
|
||||
self.assertFalse(data["error"])
|
||||
self.assertEqual(data["data"]["id"], note_id)
|
||||
self.assertEqual(data["data"]["title"], "Get Me")
|
||||
result = self.result("get_note", {"id": note_id})
|
||||
self.assertEqual(result["id"], note_id)
|
||||
self.assertEqual(result["title"], "Get Me")
|
||||
|
||||
def test_update_note(self):
|
||||
create = self._call("create_note", {"title": "Original"})
|
||||
note_id = create["data"]["id"]
|
||||
note_id = self.result("create_note", {"title": "Original"})["id"]
|
||||
|
||||
data = self._call("update_note", {"id": note_id, "title": "Updated"})
|
||||
self.assertFalse(data["error"])
|
||||
self.assertEqual(data["data"]["title"], "Updated")
|
||||
result = self.result("update_note", {"id": note_id, "title": "Updated"})
|
||||
self.assertEqual(result["title"], "Updated")
|
||||
|
||||
def test_update_note_pin(self):
|
||||
create = self._call("create_note", {"title": "Pin Me"})
|
||||
note_id = create["data"]["id"]
|
||||
note_id = self.result("create_note", {"title": "Pin Me"})["id"]
|
||||
|
||||
data = self._call("update_note", {"id": note_id, "pinned": True})
|
||||
self.assertFalse(data["error"])
|
||||
self.assertTrue(data["data"]["pinned"])
|
||||
result = self.result("update_note", {"id": note_id, "pinned": True})
|
||||
self.assertTrue(result["pinned"])
|
||||
|
||||
def test_delete_note(self):
|
||||
create = self._call("create_note", {"title": "Delete Me"})
|
||||
note_id = create["data"]["id"]
|
||||
note_id = self.result("create_note", {"title": "Delete Me"})["id"]
|
||||
|
||||
data = self._call("delete_note", {"id": note_id})
|
||||
self.assertFalse(data["error"])
|
||||
self.assertTrue(data["data"]["deleted"])
|
||||
self.assertTrue(self.result("delete_note", {"id": note_id})["deleted"])
|
||||
|
||||
# Verify it's gone
|
||||
from urllib.error import HTTPError
|
||||
# get_note raises ValueError for a missing row, which the executor maps
|
||||
# onto the generic internal-error envelope rather than a 404.
|
||||
reply = self.call("get_note", {"id": note_id})
|
||||
self.assertEqual(reply.status, 500)
|
||||
self.assertEqual(reply.body["code"], "INTERNAL_ERROR")
|
||||
|
||||
try:
|
||||
get_data = self._call("get_note", {"id": note_id})
|
||||
self.assertTrue(get_data["error"])
|
||||
except HTTPError:
|
||||
pass # 500 is also a valid failure signal
|
||||
def test_delete_absent_note_reports_not_deleted(self):
|
||||
result = self.result("delete_note", {"id": 424242})
|
||||
|
||||
self.assertFalse(result["deleted"])
|
||||
|
||||
def test_pinned_notes_sort_first(self):
|
||||
self._call("create_note", {"title": "Unpinned"})
|
||||
self._call("create_note", {"title": "Pinned", "pinned": True})
|
||||
self.result("create_note", {"title": "Unpinned"})
|
||||
self.result("create_note", {"title": "Pinned", "pinned": True})
|
||||
|
||||
data = self._call("list_notes")
|
||||
self.assertFalse(data["error"])
|
||||
self.assertEqual(data["data"]["notes"][0]["title"], "Pinned")
|
||||
result = self.result("list_notes")
|
||||
self.assertEqual(result["notes"][0]["title"], "Pinned")
|
||||
|
||||
def test_full_lifecycle(self):
|
||||
"""Create -> update -> pin -> verify -> delete over real HTTP."""
|
||||
# Create
|
||||
create = self._call("create_note", {"title": "Lifecycle", "content": "v1"})
|
||||
note_id = create["data"]["id"]
|
||||
note_id = self.result("create_note", {"title": "Lifecycle", "content": "v1"})["id"]
|
||||
|
||||
# Update
|
||||
self._call("update_note", {"id": note_id, "content": "v2"})
|
||||
self.result("update_note", {"id": note_id, "content": "v2"})
|
||||
self.result("update_note", {"id": note_id, "pinned": True})
|
||||
|
||||
# Pin
|
||||
self._call("update_note", {"id": note_id, "pinned": True})
|
||||
fetched = self.result("get_note", {"id": note_id})
|
||||
self.assertEqual(fetched["title"], "Lifecycle")
|
||||
self.assertEqual(fetched["content"], "v2")
|
||||
self.assertTrue(fetched["pinned"])
|
||||
|
||||
# Verify
|
||||
get = self._call("get_note", {"id": note_id})
|
||||
self.assertEqual(get["data"]["title"], "Lifecycle")
|
||||
self.assertEqual(get["data"]["content"], "v2")
|
||||
self.assertTrue(get["data"]["pinned"])
|
||||
|
||||
# Delete
|
||||
delete = self._call("delete_note", {"id": note_id})
|
||||
self.assertTrue(delete["data"]["deleted"])
|
||||
self.assertTrue(self.result("delete_note", {"id": note_id})["deleted"])
|
||||
|
||||
Reference in New Issue
Block a user