A channel's message slots are named from the client, on every backend
The IR called them react-message and django-message, so a FastAPI channel had to declare a DjangoMessage. They are client-message and server-message now, and the direction words hold wherever a channel is declared: Params / ClientMessage / ServerMessage, with mizan-core deriving <Pascal>Params and friends so no backend names a type itself. Django's ReactChannel and FastAPI's ReactChannel are both Channel. mizan-fastapi never registered a channels extension, so build_ir() emitted no channel at all and every payload type was invisible to codegen. It registers one now. RegistryExtension is an ABC requiring all(), which is what the IR reads — an extension that cannot enumerate its registrations no longer exists. The gate that should have caught the rename could not: tests/afi registered no channel because mizan-rust had no channel registry to register one in, so a five-package rename of the wire contract passed byte-parity without a channel byte crossing it. mizan-rust grows ChannelSlotKind, a CHANNELS slice, a #[mizan::channel] macro, and KDL emission whose wire_to_pascal matches Python's split; the AFI fixture now carries a channel with every slot and one with a single slot, so all three backends prove the contract byte for byte. MizanChannel held three Option<String> beside three has_*() predicates and unwrapped them with defaults; it holds an ordered slot vector, so an absent slot is absent rather than defaulted. The channels target emitted a React hooks file that a stage1-only consumer could not compile — react emits that now. The codegen's parity tests byte-compared emitted source against baselines without ever compiling it: they compile the generated crate and run its tests, import the generated Python package and call every method, and typecheck each TypeScript target against a consumer. Also fixed at source: app_visitor printed its import diagnostic to stdout, the stream export_mizan_ir writes KDL to, so a failed import silently corrupted the IR; the apps root was hardcoded to "apps"; _default_literal crashed build_ir on any non-JSON-serializable field default; Django and mizan-core derived Pascal names two different ways, disagreeing on every dotted channel name. ir.py builds a document and renders templates/ir/document.kdl.j2 rather than appending KDL strings with hand-tracked indentation, and named types resolve to a fixed point — a model reachable only through a union branch was referenced by a ref that no type block ever defined. The rest is the write-gate's own classifiers run over the standing tree: relative imports, silent swallows, Protocol contracts that should be ABCs, emitters hand-rendering target source, catch-all arms over closed enums, and comments narrating the project rather than the code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -1,165 +1,99 @@
|
||||
"""
|
||||
REAL integration tests for desktop system RPC functions.
|
||||
"""Desktop system and filesystem RPC functions over HTTP."""
|
||||
|
||||
These make actual HTTP requests to a running Django server.
|
||||
No RequestFactory, no mocks, no shortcuts.
|
||||
"""
|
||||
|
||||
import json
|
||||
import os
|
||||
import platform
|
||||
import shutil
|
||||
from pathlib import Path
|
||||
|
||||
from django.test import LiveServerTestCase
|
||||
from urllib.request import urlopen, Request
|
||||
|
||||
from tests.live_http import LiveRPCMixin
|
||||
|
||||
|
||||
class RealHTTPMixin:
|
||||
"""Makes real HTTP requests to the live server."""
|
||||
|
||||
def _session_init(self):
|
||||
"""Hit /session/ to get CSRF cookie, like mizanProvider does."""
|
||||
url = f"{self.live_server_url}/api/mizan/session/"
|
||||
req = Request(url)
|
||||
resp = urlopen(req)
|
||||
# Extract csrftoken from Set-Cookie header
|
||||
cookies = resp.headers.get_all("Set-Cookie") or []
|
||||
for cookie in cookies:
|
||||
if "csrftoken=" in cookie:
|
||||
self._csrf_token = cookie.split("csrftoken=")[1].split(";")[0]
|
||||
self._cookies = f"csrftoken={self._csrf_token}"
|
||||
return
|
||||
self._csrf_token = None
|
||||
self._cookies = ""
|
||||
|
||||
def _call(self, fn: str, args: dict | None = None):
|
||||
"""Make a real POST to /api/mizan/call/ with CSRF token."""
|
||||
url = f"{self.live_server_url}/api/mizan/call/"
|
||||
body = json.dumps({"fn": fn, "args": args or {}}).encode()
|
||||
req = Request(url, data=body, method="POST")
|
||||
req.add_header("Content-Type", "application/json")
|
||||
if self._csrf_token:
|
||||
req.add_header("X-CSRFToken", self._csrf_token)
|
||||
if self._cookies:
|
||||
req.add_header("Cookie", self._cookies)
|
||||
resp = urlopen(req)
|
||||
return json.loads(resp.read())
|
||||
|
||||
|
||||
class SystemInfoTests(RealHTTPMixin, LiveServerTestCase):
|
||||
"""system_info over real HTTP."""
|
||||
|
||||
class SystemInfoTests(LiveRPCMixin, LiveServerTestCase):
|
||||
def setUp(self):
|
||||
self._session_init()
|
||||
self.session_init()
|
||||
|
||||
def test_system_info_returns_os_data(self):
|
||||
data = self._call("system_info")
|
||||
result = self.result("system_info")
|
||||
|
||||
self.assertFalse(data["error"])
|
||||
self.assertEqual(data["data"]["os_name"], platform.system())
|
||||
self.assertEqual(data["data"]["hostname"], platform.node())
|
||||
self.assertGreater(data["data"]["cpu_count"], 0)
|
||||
self.assertEqual(result["os_name"], platform.system())
|
||||
self.assertEqual(result["hostname"], platform.node())
|
||||
self.assertGreater(result["cpu_count"], 0)
|
||||
|
||||
def test_system_info_returns_paths(self):
|
||||
data = self._call("system_info")
|
||||
result = self.result("system_info")
|
||||
|
||||
self.assertFalse(data["error"])
|
||||
self.assertEqual(data["data"]["home_dir"], str(Path.home()))
|
||||
self.assertEqual(data["data"]["cwd"], os.getcwd())
|
||||
self.assertEqual(result["home_dir"], str(Path.home()))
|
||||
self.assertEqual(result["cwd"], os.getcwd())
|
||||
|
||||
def test_disk_usage(self):
|
||||
data = self._call("disk_usage", {"path": "/"})
|
||||
result = self.result("disk_usage", {"path": "/"})
|
||||
|
||||
self.assertFalse(data["error"])
|
||||
self.assertGreater(data["data"]["total_gb"], 0)
|
||||
self.assertGreater(data["data"]["free_gb"], 0)
|
||||
self.assertGreaterEqual(data["data"]["percent_used"], 0)
|
||||
self.assertLessEqual(data["data"]["percent_used"], 100)
|
||||
self.assertGreater(result["total_gb"], 0)
|
||||
self.assertGreater(result["free_gb"], 0)
|
||||
self.assertGreaterEqual(result["percent_used"], 0)
|
||||
self.assertLessEqual(result["percent_used"], 100)
|
||||
|
||||
def test_app_info(self):
|
||||
data = self._call("app_info")
|
||||
result = self.result("app_info")
|
||||
|
||||
self.assertFalse(data["error"])
|
||||
self.assertEqual(data["data"]["app_name"], "mizan Desktop")
|
||||
self.assertGreater(data["data"]["uptime_seconds"], 0)
|
||||
self.assertEqual(result["app_name"], "mizan Desktop")
|
||||
self.assertGreater(result["uptime_seconds"], 0)
|
||||
|
||||
|
||||
class FileSystemTests(RealHTTPMixin, LiveServerTestCase):
|
||||
"""File system RPC over real HTTP."""
|
||||
|
||||
class FileSystemTests(LiveRPCMixin, LiveServerTestCase):
|
||||
def setUp(self):
|
||||
self._session_init()
|
||||
self.session_init()
|
||||
self.test_dir = Path.home() / ".mizan-test"
|
||||
self.test_dir.mkdir(exist_ok=True)
|
||||
|
||||
def tearDown(self):
|
||||
import shutil
|
||||
|
||||
if self.test_dir.exists():
|
||||
shutil.rmtree(self.test_dir)
|
||||
|
||||
def test_list_files_home(self):
|
||||
data = self._call("list_files", {"directory": "~"})
|
||||
result = self.result("list_files", {"directory": "~"})
|
||||
|
||||
self.assertFalse(data["error"])
|
||||
self.assertEqual(data["data"]["directory"], str(Path.home()))
|
||||
self.assertIsInstance(data["data"]["entries"], list)
|
||||
self.assertEqual(result["directory"], str(Path.home()))
|
||||
self.assertIsInstance(result["entries"], list)
|
||||
|
||||
def test_list_files_root_has_no_parent(self):
|
||||
data = self._call("list_files", {"directory": "/"})
|
||||
result = self.result("list_files", {"directory": "/"})
|
||||
|
||||
self.assertFalse(data["error"])
|
||||
self.assertIsNone(data["data"]["parent"])
|
||||
self.assertIsNone(result["parent"])
|
||||
|
||||
def test_write_and_read_file(self):
|
||||
"""Full round-trip over real HTTP: write, read back, verify."""
|
||||
test_path = str(self.test_dir / "test-note.txt")
|
||||
test_content = "Hello from a REAL HTTP integration test!"
|
||||
test_content = "Hello from an HTTP integration test!"
|
||||
|
||||
# Write
|
||||
write_data = self._call(
|
||||
"write_file", {"path": test_path, "content": test_content}
|
||||
)
|
||||
self.assertFalse(write_data["error"])
|
||||
self.assertEqual(write_data["data"]["path"], test_path)
|
||||
written = self.result("write_file", {"path": test_path, "content": test_content})
|
||||
self.assertEqual(written["path"], test_path)
|
||||
|
||||
# Read back
|
||||
read_data = self._call("read_file", {"path": test_path})
|
||||
self.assertFalse(read_data["error"])
|
||||
self.assertEqual(read_data["data"]["content"], test_content)
|
||||
read_back = self.result("read_file", {"path": test_path})
|
||||
self.assertEqual(read_back["content"], test_content)
|
||||
|
||||
def test_write_outside_home_rejected(self):
|
||||
"""Server should reject writes outside home directory."""
|
||||
from urllib.error import HTTPError
|
||||
reply = self.call("write_file", {"path": "/tmp/escape.txt", "content": "nope"})
|
||||
|
||||
try:
|
||||
data = self._call(
|
||||
"write_file", {"path": "/tmp/escape.txt", "content": "nope"}
|
||||
)
|
||||
# If we get here, check the response has an error
|
||||
self.assertTrue(data["error"])
|
||||
self.assertEqual(data["code"], "FORBIDDEN")
|
||||
except HTTPError as e:
|
||||
# 403 is also acceptable
|
||||
self.assertEqual(e.code, 403)
|
||||
self.assertEqual(reply.status, 403)
|
||||
self.assertEqual(reply.body["code"], "FORBIDDEN")
|
||||
|
||||
def test_delete_file(self):
|
||||
test_path = str(self.test_dir / "to-delete.txt")
|
||||
(self.test_dir / "to-delete.txt").write_text("delete me")
|
||||
|
||||
data = self._call("delete_file", {"path": test_path})
|
||||
self.assertFalse(data["error"])
|
||||
self.assertTrue(data["data"]["deleted"])
|
||||
result = self.result("delete_file", {"path": test_path})
|
||||
self.assertTrue(result["deleted"])
|
||||
self.assertFalse(Path(test_path).exists())
|
||||
|
||||
def test_file_entries_have_metadata(self):
|
||||
(self.test_dir / "metadata-test.txt").write_text("hello")
|
||||
|
||||
data = self._call("list_files", {"directory": str(self.test_dir)})
|
||||
self.assertFalse(data["error"])
|
||||
self.assertGreater(len(data["data"]["entries"]), 0)
|
||||
result = self.result("list_files", {"directory": str(self.test_dir)})
|
||||
self.assertGreater(len(result["entries"]), 0)
|
||||
|
||||
entry = data["data"]["entries"][0]
|
||||
entry = result["entries"][0]
|
||||
self.assertIn("name", entry)
|
||||
self.assertIn("path", entry)
|
||||
self.assertIn("is_dir", entry)
|
||||
|
||||
Reference in New Issue
Block a user