Ryth Azhur
3aafec6dd4
The IR called them react-message and django-message, so a FastAPI channel had to declare a DjangoMessage. They are client-message and server-message now, and the direction words hold wherever a channel is declared: Params / ClientMessage / ServerMessage, with mizan-core deriving <Pascal>Params and friends so no backend names a type itself. Django's ReactChannel and FastAPI's ReactChannel are both Channel. mizan-fastapi never registered a channels extension, so build_ir() emitted no channel at all and every payload type was invisible to codegen. It registers one now. RegistryExtension is an ABC requiring all(), which is what the IR reads — an extension that cannot enumerate its registrations no longer exists. The gate that should have caught the rename could not: tests/afi registered no channel because mizan-rust had no channel registry to register one in, so a five-package rename of the wire contract passed byte-parity without a channel byte crossing it. mizan-rust grows ChannelSlotKind, a CHANNELS slice, a #[mizan::channel] macro, and KDL emission whose wire_to_pascal matches Python's split; the AFI fixture now carries a channel with every slot and one with a single slot, so all three backends prove the contract byte for byte. MizanChannel held three Option<String> beside three has_*() predicates and unwrapped them with defaults; it holds an ordered slot vector, so an absent slot is absent rather than defaulted. The channels target emitted a React hooks file that a stage1-only consumer could not compile — react emits that now. The codegen's parity tests byte-compared emitted source against baselines without ever compiling it: they compile the generated crate and run its tests, import the generated Python package and call every method, and typecheck each TypeScript target against a consumer. Also fixed at source: app_visitor printed its import diagnostic to stdout, the stream export_mizan_ir writes KDL to, so a failed import silently corrupted the IR; the apps root was hardcoded to "apps"; _default_literal crashed build_ir on any non-JSON-serializable field default; Django and mizan-core derived Pascal names two different ways, disagreeing on every dotted channel name. ir.py builds a document and renders templates/ir/document.kdl.j2 rather than appending KDL strings with hand-tracked indentation, and named types resolve to a fixed point — a model reachable only through a union branch was referenced by a ref that no type block ever defined. The rest is the write-gate's own classifiers run over the standing tree: relative imports, silent swallows, Protocol contracts that should be ABCs, emitters hand-rendering target source, catch-all arms over closed enums, and comments narrating the project rather than the code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
122 lines
3.8 KiB
TypeScript
122 lines
3.8 KiB
TypeScript
import { ReactContext, type ClientOptions, type RegistryEntry, type ParamDef } from './types'
|
|
import { register } from './registry'
|
|
|
|
function resolveContext(ctx: ReactContext | string | undefined): string | undefined {
|
|
if (ctx instanceof ReactContext) return ctx.name
|
|
return ctx
|
|
}
|
|
|
|
function normalizeAffects(
|
|
affects: ClientOptions['affects'],
|
|
): RegistryEntry['affects'] | undefined {
|
|
if (!affects) return undefined
|
|
|
|
const items = Array.isArray(affects) ? affects : [affects]
|
|
return items.map(item => {
|
|
if (item instanceof ReactContext) {
|
|
return { type: 'context' as const, name: item.name }
|
|
}
|
|
return { type: 'context' as const, name: item }
|
|
})
|
|
}
|
|
|
|
/**
|
|
* Recover parameter names by parsing the function's own source text.
|
|
*
|
|
* Names are the wire contract — the dispatcher matches request params to
|
|
* positional arguments by name — and JS erases them at runtime, so the
|
|
* source string is the only place they survive.
|
|
*/
|
|
function extractParams(fn: Function): ParamDef[] {
|
|
const source = fn.toString()
|
|
const match = source.match(/\(([^)]*)\)/)
|
|
if (!match || !match[1].trim()) return []
|
|
|
|
return match[1]
|
|
.split(',')
|
|
.map(p => p.trim())
|
|
.filter(p => p && !p.startsWith('...'))
|
|
.map(p => {
|
|
// Strips a default value or a type annotation off the name
|
|
const name = p.split(/[=:]/)[0].trim()
|
|
return { name, type: 'any', required: !p.includes('=') }
|
|
})
|
|
}
|
|
|
|
/** Wrap and register a standalone function. */
|
|
export function client<T extends (...args: any[]) => Promise<any>>(
|
|
options: ClientOptions,
|
|
fn: T,
|
|
): T
|
|
|
|
/** Register a class method. */
|
|
export function client(options: ClientOptions): MethodDecorator
|
|
|
|
export function client(optionsOrFn: ClientOptions, fn?: Function): any {
|
|
// Function wrapper form: client(options, fn)
|
|
if (fn && typeof fn === 'function') {
|
|
const options = optionsOrFn as ClientOptions
|
|
const context = resolveContext(options.context)
|
|
const affects = normalizeAffects(options.affects)
|
|
|
|
if (context && affects) {
|
|
throw new Error('context and affects are mutually exclusive')
|
|
}
|
|
|
|
const name = fn.name || 'anonymous'
|
|
const params = extractParams(fn)
|
|
|
|
const entry: RegistryEntry = {
|
|
name,
|
|
fn: fn as RegistryEntry['fn'],
|
|
context,
|
|
affects,
|
|
params,
|
|
private: options.private ?? false,
|
|
// A wrapped function's return is only known once called, so the
|
|
// view-vs-RPC split is decided by the dispatcher, not here.
|
|
viewPath: false,
|
|
route: options.route,
|
|
methods: options.methods,
|
|
auth: options.auth,
|
|
rev: options.rev,
|
|
cache: options.cache,
|
|
}
|
|
|
|
register(entry)
|
|
return fn
|
|
}
|
|
|
|
// Decorator form: @client(options)
|
|
const options = optionsOrFn as ClientOptions
|
|
return function (_target: any, propertyKey: string, descriptor: PropertyDescriptor) {
|
|
const originalMethod = descriptor.value
|
|
const context = resolveContext(options.context)
|
|
const affects = normalizeAffects(options.affects)
|
|
|
|
if (context && affects) {
|
|
throw new Error('context and affects are mutually exclusive')
|
|
}
|
|
|
|
const params = extractParams(originalMethod)
|
|
|
|
const entry: RegistryEntry = {
|
|
name: propertyKey,
|
|
fn: originalMethod,
|
|
context,
|
|
affects,
|
|
params,
|
|
private: options.private ?? false,
|
|
viewPath: false,
|
|
route: options.route,
|
|
methods: options.methods,
|
|
auth: options.auth,
|
|
rev: options.rev,
|
|
cache: options.cache,
|
|
}
|
|
|
|
register(entry)
|
|
return descriptor
|
|
}
|
|
}
|